I have to say that one of the biggest changes in my lifetime, is the phenomenon of men wearing shorts. Men never wore shorts when I was young. There are few things I would rather see less, to tell you the truth. I'd just as soon see someone coming toward me with a hand grenade. This is one of the worst changes, by far. It's disgusting. To have to sit next to grown men on the subway in the summer, and they're wearing shorts? It's repulsive. They look ridiculous, like children, and I can't take them seriously.
It's like any other sort of revealing clothing, in that the people you'd most like to see them on aren't wearing them. And if they are, it's probably their job to wear them. My fashion advice, particularly to men wearing shorts: Ask yourself, 'Could I make a living modeling these shorts?' If the answer is no, then change your clothes. Put on a pair of pants.